nsivabalan commented on a change in pull request #3315:
URL: https://github.com/apache/hudi/pull/3315#discussion_r678625840
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java
##########
@@ -87,6 +93,20 @@
fsCache.put(metaClient, fsView);
}
HoodieTableFileSystemView fsView = fsCache.get(metaClient);
+ // fetch virtual key params if required.
Review comment:
@vinothchandar : quick question. here we have a N no of metaclients, one
per partition path (line 86).
Is it safe to assume all partitions have same schema? Then, should I move
this outside of foreach and just pick first entry and find the tableConfig to
populate hoodieVirtualKeyInfo. If not, we are fetching the schema for every
partition to find the hoodieVirtualKeyInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
