nsivabalan commented on a change in pull request #3315:
URL: https://github.com/apache/hudi/pull/3315#discussion_r678633348
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##########
@@ -82,6 +82,13 @@
public static final int HOODIE_PARTITION_PATH_COL_POS = 3;
public static final String HOODIE_READ_COLUMNS_PROP =
"hoodie.read.columns.set";
+ public static final String HOODIE_USE_META_FIELDS = "hoodie.use.meta.fields";
Review comment:
I am not sure If I fully go with that just in this specific context. In
general, I agree having the same property throughout makes sense. but here,
somehow I feel its not very apparent.
populateMetaFields is something clearly on the write path(as it conveys
whether to populate meta fields or not). I would expect something like
"hasMetaFields" or something for read path.
Or we could rename the entire property to "enableMetaFields" or something so
that both write and read side makes sense.
Anyways, w/ latest fix, we may not need these variables only. will remove
them. just wanted to convey my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
