[
https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389055#comment-17389055
]
ASF GitHub Bot commented on HUDI-2177:
--------------------------------------
nsivabalan commented on a change in pull request #3315:
URL: https://github.com/apache/hudi/pull/3315#discussion_r678634080
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java
##########
@@ -60,7 +60,7 @@ public static String
getRecordKeyFromGenericRecord(GenericRecord genericRecord,
* @return the partition path for the passed in generic record.
*/
public static String getPartitionPathFromGenericRecord(GenericRecord
genericRecord, Option<BaseKeyGenerator> keyGeneratorOpt) {
- return keyGeneratorOpt.isPresent() ?
keyGeneratorOpt.get().getRecordKey(genericRecord) :
genericRecord.get(HoodieRecord.PARTITION_PATH_METADATA_FIELD).toString();
+ return keyGeneratorOpt.isPresent() ?
keyGeneratorOpt.get().getPartitionPath(genericRecord) :
genericRecord.get(HoodieRecord.PARTITION_PATH_METADATA_FIELD).toString();
Review comment:
yes, I have tests succeeding at writeClient, spark datasource and
deltastreamer as well for both COW and MOR.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java
##########
@@ -60,7 +60,7 @@ public static String
getRecordKeyFromGenericRecord(GenericRecord genericRecord,
* @return the partition path for the passed in generic record.
*/
public static String getPartitionPathFromGenericRecord(GenericRecord
genericRecord, Option<BaseKeyGenerator> keyGeneratorOpt) {
- return keyGeneratorOpt.isPresent() ?
keyGeneratorOpt.get().getRecordKey(genericRecord) :
genericRecord.get(HoodieRecord.PARTITION_PATH_METADATA_FIELD).toString();
+ return keyGeneratorOpt.isPresent() ?
keyGeneratorOpt.get().getPartitionPath(genericRecord) :
genericRecord.get(HoodieRecord.PARTITION_PATH_METADATA_FIELD).toString();
Review comment:
yes, we have tests succeeding at writeClient, spark datasource and
deltastreamer as well for both COW and MOR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Virtual keys support for Compaction
> -----------------------------------
>
> Key: HUDI-2177
> URL: https://issues.apache.org/jira/browse/HUDI-2177
> Project: Apache Hudi
> Issue Type: Sub-task
> Components: Writer Core
> Reporter: sivabalan narayanan
> Assignee: sivabalan narayanan
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Virtual keys support for Compaction
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
