[
https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389082#comment-17389082
]
ASF GitHub Bot commented on HUDI-2177:
--------------------------------------
nsivabalan commented on a change in pull request #3315:
URL: https://github.com/apache/hudi/pull/3315#discussion_r678658288
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java
##########
@@ -302,7 +310,12 @@ private void processDataBlock(HoodieDataBlock dataBlock)
throws Exception {
}
protected HoodieRecord<?> createHoodieRecord(IndexedRecord rec) {
- return SpillableMapUtils.convertToHoodieRecordPayload((GenericRecord) rec,
this.payloadClassFQN);
+ if (!simpleRecordKeyFieldOpt.isPresent()) {
Review comment:
not sure if I tried it here or for keyGen related code blocks. But what
I found was, if
```
Option.map.ofElse
```
is called just once, it works smoothly. But if this piece of code gets
called N no of times repeatedly, I ran into issues.
I will try it out again just to confirm my understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Virtual keys support for Compaction
> -----------------------------------
>
> Key: HUDI-2177
> URL: https://issues.apache.org/jira/browse/HUDI-2177
> Project: Apache Hudi
> Issue Type: Sub-task
> Components: Writer Core
> Reporter: sivabalan narayanan
> Assignee: sivabalan narayanan
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Virtual keys support for Compaction
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
