yihua commented on a change in pull request #3743:
URL: https://github.com/apache/hudi/pull/3743#discussion_r722936242
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/WriteMarkersFactory.java
##########
@@ -34,24 +36,28 @@
private static final Logger LOG =
LogManager.getLogger(WriteMarkersFactory.class);
/**
- * @param markerType the type of markers to use
- * @param table {@code HoodieTable} instance
+ * @param markerType the type of markers to use
+ * @param metaClient {@link HoodieTableMetaClient} instance to use
+ * @param config Write config
+ * @param context {@link HoodieEngineContext} instance to use
* @param instantTime current instant time
- * @return {@code WriteMarkers} instance based on the {@code MarkerType}
+ * @return {@code WriteMarkers} instance based on the {@code MarkerType}
*/
- public static WriteMarkers get(MarkerType markerType, HoodieTable table,
String instantTime) {
+ public static WriteMarkers get(
+ MarkerType markerType, HoodieTableMetaClient metaClient,
HoodieWriteConfig config,
Review comment:
Right. I revert the changes to the markers-related APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
