yihua commented on a change in pull request #3743:
URL: https://github.com/apache/hudi/pull/3743#discussion_r722936410
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java
##########
@@ -120,21 +120,24 @@ static HoodieRollbackStat
mergeRollbackStat(HoodieRollbackStat stat1, HoodieRoll
* Generate all rollback requests that we need to perform for rolling back
this action without actually performing rolling back for MOR table type.
*
* @param instantToRollback Instant to Rollback
- * @param table instance of {@link HoodieTable} to use.
- * @param context instance of {@link HoodieEngineContext} to use.
+ * @param metaClient instance of {@link HoodieTableMetaClient} to use.
+ * @param config Write config.
+ * @param context instance of {@link HoodieEngineContext} to use.
+ * @param fileSystemView File system view.
* @return list of rollback requests
*/
- public static List<ListingBasedRollbackRequest>
generateRollbackRequestsUsingFileListingMOR(HoodieInstant instantToRollback,
HoodieTable table, HoodieEngineContext context) throws IOException {
+ public static List<ListingBasedRollbackRequest>
generateRollbackRequestsUsingFileListingMOR(
+ HoodieInstant instantToRollback, HoodieTableMetaClient metaClient,
HoodieWriteConfig config,
+ HoodieEngineContext context, TableFileSystemView.SliceView
fileSystemView) throws IOException {
Review comment:
The sliceView arguement is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
