nsivabalan commented on a change in pull request #3740:
URL: https://github.com/apache/hudi/pull/3740#discussion_r725212936
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java
##########
@@ -710,6 +710,57 @@ private void testHoodieConcatHandle(HoodieWriteConfig
config, boolean isPrepped)
2, false, config.populateMetaFields());
}
+ /**
+ * Test Insert API for HoodieConcatHandle when incoming entries contain
duplicate keys.
+ */
+ @ParameterizedTest
+ @MethodSource("populateMetaFieldsParams")
Review comment:
we don't need to test for case where populateMetaFieldsParams = false.
we are trying to keep a check on our test run time. Can we please remove the
parametrized for the new tests that are being added.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -257,6 +257,21 @@ private boolean writeUpdateRecord(HoodieRecord<T>
hoodieRecord, Option<IndexedRe
return writeRecord(hoodieRecord, indexedRecord);
}
+ protected boolean writeInsertRecord(HoodieRecord<T> hoodieRecord) throws
IOException {
Review comment:
sorry. last few nits.
we don't really need to return a boolean here.
```
if (insertRecord.isPresent() && insertRecord.get().equals(IGNORE_RECORD)) {
return;
}
```
both callers are not using the return value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
