helanto commented on a change in pull request #3740:
URL: https://github.com/apache/hudi/pull/3740#discussion_r725275190



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -257,6 +257,21 @@ private boolean writeUpdateRecord(HoodieRecord<T> 
hoodieRecord, Option<IndexedRe
     return writeRecord(hoodieRecord, indexedRecord);
   }
 
+  protected boolean writeInsertRecord(HoodieRecord<T> hoodieRecord) throws 
IOException {

Review comment:
       I noticed that to be honest. I decided to go with `boolean` just to keep 
it consistent with methods `writeUpdateRecord` and `writeRecord`. I will change!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to