yihua commented on a change in pull request #3778:
URL: https://github.com/apache/hudi/pull/3778#discussion_r738016333
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java
##########
@@ -85,7 +85,8 @@
/**
* Hoodie Index implementation backed by HBase.
*/
-public class SparkHoodieHBaseIndex<T extends HoodieRecordPayload<T>> extends
HoodieIndex<T> {
+public class SparkHoodieHBaseIndex<T extends HoodieRecordPayload<T>>
+ extends HoodieIndex<T, JavaRDD<HoodieRecord<T>>, JavaRDD<HoodieKey>,
JavaRDD<WriteStatus>> {
Review comment:
So for all internal indices, I make them directly extend `HoodieIndex`.
The `JavaRDD<HoodieRecord<T>>, JavaRDD<HoodieKey>, JavaRDD<WriteStatus>` for
`I, K, O` are anyway not used by the new APIs, and they're not supposed to be
used in the new abstraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
