yihua commented on a change in pull request #3778:
URL: https://github.com/apache/hudi/pull/3778#discussion_r738016600
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/HoodieBloomIndexHelper.java
##########
@@ -20,41 +20,22 @@
package org.apache.hudi.index.bloom;
import org.apache.hudi.common.data.HoodieData;
-import org.apache.hudi.common.data.HoodieList;
import org.apache.hudi.common.data.HoodiePairData;
import org.apache.hudi.common.engine.HoodieEngineContext;
import org.apache.hudi.common.model.HoodieKey;
import org.apache.hudi.common.model.HoodieRecordLocation;
import org.apache.hudi.common.util.collection.ImmutablePair;
-import org.apache.hudi.common.util.collection.Pair;
import org.apache.hudi.config.HoodieWriteConfig;
-import org.apache.hudi.io.HoodieKeyLookupHandle.KeyLookupResult;
import org.apache.hudi.table.HoodieTable;
import java.io.Serializable;
-import java.util.ArrayList;
-import java.util.Comparator;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
-import static java.util.stream.Collectors.toList;
-
/**
- * Helper for {@link HoodieBloomIndex} containing engine-specific logic,
- * with default logic supporting Java engines.
+ * Helper for {@link HoodieBloomIndex} containing engine-specific logic.
*/
-public class HoodieBloomIndexHelper implements Serializable {
-
- private static final HoodieBloomIndexHelper SINGLETON_INSTANCE = new
HoodieBloomIndexHelper();
-
- protected HoodieBloomIndexHelper() {
- }
-
- public static HoodieBloomIndexHelper getInstance() {
- return SINGLETON_INSTANCE;
- }
-
+public abstract class HoodieBloomIndexHelper implements Serializable {
Review comment:
Yes. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
