YannByron commented on a change in pull request #3936:
URL: https://github.com/apache/hudi/pull/3936#discussion_r745325819
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableDropPartitionCommand.scala
##########
@@ -104,10 +104,6 @@ extends RunnableCommand {
PARTITIONPATH_FIELD.key -> tableConfig.getPartitionFieldProp
)
}
-
- val parameters = HoodieWriterUtils.parametersWithWriteDefaults(optParams)
- val translatedOptions =
DataSourceWriteOptions.translateSqlOptions(parameters)
- translatedOptions
Review comment:
Appending default parameters and translating sql options will be
executed in `HoodieSparkSqlWriter.mergeParamsAndGetHoodieConfig`. In Sql
Command, the raw parameters passing to `HoodieSparkSqlWriter.write` will be
used to check conflicts between parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
