YannByron commented on a change in pull request #3936:
URL: https://github.com/apache/hudi/pull/3936#discussion_r747356716
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
##########
@@ -242,8 +244,13 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Runnab
// Append the table schema to the parameters. In the case of merge into,
the schema of sourceDF
// may be different from the target table, because the are transform
logical in the update or
// insert actions.
+ val opertion = if
(StringUtils.isNullOrEmpty(parameters.getOrElse(PRECOMBINE_FIELD.key, ""))) {
Review comment:
Yes, this behavior keeps consistent with dataframe api.
if no PRECOMBINE_FIELD is specified, will throw exception if use `upsert`,
but will work if use `insert`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
