prashantwason commented on a change in pull request #3947:
URL: https://github.com/apache/hudi/pull/3947#discussion_r748582162
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java
##########
@@ -127,7 +126,7 @@ static HoodieRollbackStat
mergeRollbackStat(HoodieRollbackStat stat1, HoodieRoll
public static List<ListingBasedRollbackRequest>
generateRollbackRequestsUsingFileListingMOR(HoodieInstant instantToRollback,
HoodieTable table, HoodieEngineContext context) throws IOException {
String commit = instantToRollback.getTimestamp();
HoodieWriteConfig config = table.getConfig();
- List<String> partitions = FSUtils.getAllPartitionPaths(context,
config.getMetadataConfig(), table.getMetaClient().getBasePath());
+ List<String> partitions = FSUtils.getAllPartitionPaths(context,
table.getMetaClient().getBasePath(), false, false);
Review comment:
minor: I see various versions of FSUtils.getAllPartitionPaths(...) which
have similar code. Maybe remove code duplication there.
not essential though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
