prashantwason commented on a change in pull request #3947:
URL: https://github.com/apache/hudi/pull/3947#discussion_r748582856
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java
##########
@@ -106,12 +107,10 @@ static HoodieRollbackStat
mergeRollbackStat(HoodieRollbackStat stat1, HoodieRoll
* Generate all rollback requests that needs rolling back this action
without actually performing rollback for COW table type.
* @param engineContext instance of {@link HoodieEngineContext} to use.
* @param basePath base path of interest.
- * @param config instance of {@link HoodieWriteConfig} to use.
* @return {@link List} of {@link ListingBasedRollbackRequest}s thus
collected.
*/
- public static List<ListingBasedRollbackRequest>
generateRollbackRequestsByListingCOW(HoodieEngineContext engineContext,
-
String basePath, HoodieWriteConfig config) {
- return FSUtils.getAllPartitionPaths(engineContext,
config.getMetadataConfig(), basePath).stream()
+ public static List<ListingBasedRollbackRequest>
generateRollbackRequestsByListingCOW(HoodieEngineContext engineContext, String
basePath) {
+ return FSUtils.getAllPartitionPaths(engineContext, basePath, false,
false).stream()
Review comment:
So listing based rollback does not use metadata table any longer. Is
this the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
