prashantwason commented on a change in pull request #3968:
URL: https://github.com/apache/hudi/pull/3968#discussion_r748591215
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFileReader.java
##########
@@ -251,11 +256,12 @@ private HoodieLogBlock readBlock() throws IOException {
return HoodieAvroDataBlock.getBlock(content, readerSchema);
} else {
return new HoodieAvroDataBlock(logFile, inputStream,
Option.ofNullable(content), readBlockLazily,
- contentPosition, contentLength, blockEndPos, readerSchema,
header, footer);
+ contentPosition, contentLength, blockEndPos, readerSchema,
header, footer, this.keyField);
Review comment:
to be consistent with other arguments, "this" can be dropped for
keyField.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFileReader.java
##########
@@ -251,11 +256,12 @@ private HoodieLogBlock readBlock() throws IOException {
return HoodieAvroDataBlock.getBlock(content, readerSchema);
} else {
return new HoodieAvroDataBlock(logFile, inputStream,
Option.ofNullable(content), readBlockLazily,
- contentPosition, contentLength, blockEndPos, readerSchema,
header, footer);
+ contentPosition, contentLength, blockEndPos, readerSchema,
header, footer, this.keyField);
}
case HFILE_DATA_BLOCK:
return new HoodieHFileDataBlock(logFile, inputStream,
Option.ofNullable(content), readBlockLazily,
- contentPosition, contentLength, blockEndPos, readerSchema,
header, footer, enableInlineReading);
+ contentPosition, contentLength, blockEndPos, readerSchema,
+ header, footer, enableInlineReading, this.keyField);
Review comment:
to be consistent with other arguments, "this" can be dropped for
keyField.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
