prashantwason commented on a change in pull request #3968:
URL: https://github.com/apache/hudi/pull/3968#discussion_r748592506
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
##########
@@ -151,6 +155,14 @@ protected AbstractHoodieLogRecordReader(FileSystem fs,
String basePath, List<Str
this.instantRange = instantRange;
this.withOperationField = withOperationField;
this.enableFullScan = enableFullScan;
+
+ // virtual keys handling
+ if (!tableConfig.populateMetaFields()) {
+ this.virtualKeysEnabled = true;
+ this.simpleKeyGenFields = Option.of(
+ Pair.of(tableConfig.getRecordKeyFieldProp(),
tableConfig.getPartitionFieldProp()));
+ }
+ this.partitionName = partitionName;
Review comment:
Path refers to the full path. Name is the relative part. I think we need
the latter here so its not a path actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
