manojpec commented on a change in pull request #3968:
URL: https://github.com/apache/hudi/pull/3968#discussion_r749729504
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
##########
@@ -343,11 +362,13 @@ private void processDataBlock(HoodieDataBlock dataBlock,
Option<List<String>> ke
}
}
- protected HoodieRecord<?> createHoodieRecord(IndexedRecord rec) {
- if (!simpleKeyGenFields.isPresent()) {
- return SpillableMapUtils.convertToHoodieRecordPayload((GenericRecord)
rec, this.payloadClassFQN, this.preCombineField, this.withOperationField);
+ private HoodieRecord<?> createHoodieRecord(IndexedRecord rec) {
+ if (!virtualKeysEnabled) {
+ return SpillableMapUtils.convertToHoodieRecordPayload((GenericRecord)
rec, this.payloadClassFQN,
+ this.preCombineField, this.withOperationField);
} else {
- return SpillableMapUtils.convertToHoodieRecordPayload((GenericRecord)
rec, this.payloadClassFQN, this.preCombineField, this.simpleKeyGenFields.get(),
this.withOperationField);
+ return SpillableMapUtils.convertToHoodieRecordPayload((GenericRecord)
rec, this.payloadClassFQN,
Review comment:
Right, good suggestion. Made the derived
HoodieMetadataMergedLogRecordReader to take care of any special creation of
hoodie record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
