manojpec commented on a change in pull request #3968:
URL: https://github.com/apache/hudi/pull/3968#discussion_r749729587
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/SpillableMapUtils.java
##########
@@ -115,22 +115,28 @@ public static long generateChecksum(byte[] data) {
* Utility method to convert bytes to HoodieRecord using schema and payload
class.
*/
public static <R> R convertToHoodieRecordPayload(GenericRecord rec, String
payloadClazz, String preCombineField, boolean withOperationField) {
- return convertToHoodieRecordPayload(rec, payloadClazz, preCombineField,
Pair.of(HoodieRecord.RECORD_KEY_METADATA_FIELD,
HoodieRecord.PARTITION_PATH_METADATA_FIELD), withOperationField);
+ return convertToHoodieRecordPayload(rec, payloadClazz, preCombineField,
Pair.of(HoodieRecord.RECORD_KEY_METADATA_FIELD,
HoodieRecord.PARTITION_PATH_METADATA_FIELD),
+ withOperationField, Option.empty());
}
/**
* Utility method to convert bytes to HoodieRecord using schema and payload
class.
*/
- public static <R> R convertToHoodieRecordPayload(GenericRecord rec, String
payloadClazz,
- String preCombineField,
Pair<String, String> recordKeyPartitionPathPair,
- boolean withOperationField)
{
- String recKey = rec.get(recordKeyPartitionPathPair.getLeft()).toString();
- String partitionPath =
rec.get(recordKeyPartitionPathPair.getRight()).toString();
- Object preCombineVal = getPreCombineVal(rec, preCombineField);
+ public static <R> R convertToHoodieRecordPayload(GenericRecord record,
String payloadClazz,
+ String preCombineField,
+ Pair<String, String>
recordKeyPartitionPathPair,
+ boolean withOperationField,
+ Option<String>
partitionName) {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
