satishkotha commented on a change in pull request #3970:
URL: https://github.com/apache/hudi/pull/3970#discussion_r752852132
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/SparkClientFunctionalTestHarness.java
##########
@@ -228,8 +228,8 @@ protected void insertRecords(HoodieTableMetaClient
metaClient, List<HoodieRecord
roView = getHoodieTableFileSystemView(reloadedMetaClient,
hoodieTable.getCompletedCommitsTimeline(), allFiles);
dataFilesToRead = roView.getLatestBaseFiles();
- assertTrue(dataFilesToRead.findAny().isPresent(),
- "should list the base files we wrote in the delta commit");
+ assertEquals(!hoodieTable.getIndex().canIndexLogFiles(),
dataFilesToRead.findAny().isPresent(),
Review comment:
is this change related? I dont fully get the reasoning. I think base
files can still be present (for example, after compaction/clustering) even if
canIndexLogFiles is true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
