codope commented on a change in pull request #3970:
URL: https://github.com/apache/hudi/pull/3970#discussion_r752857703
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/SparkClientFunctionalTestHarness.java
##########
@@ -228,8 +228,8 @@ protected void insertRecords(HoodieTableMetaClient
metaClient, List<HoodieRecord
roView = getHoodieTableFileSystemView(reloadedMetaClient,
hoodieTable.getCompletedCommitsTimeline(), allFiles);
dataFilesToRead = roView.getLatestBaseFiles();
- assertTrue(dataFilesToRead.findAny().isPresent(),
- "should list the base files we wrote in the delta commit");
+ assertEquals(!hoodieTable.getIndex().canIndexLogFiles(),
dataFilesToRead.findAny().isPresent(),
Review comment:
This method is being used to do first couple of inserts before the
compaction/clustering is triggered. With canIndexLogFiles true, those inserts
will only write log files. However, I see your point. I think we should not
have this assertion here at all. It should be within respective tests. This
method should only be concerned with inserting records. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
