yihua commented on a change in pull request #4037:
URL: https://github.com/apache/hudi/pull/4037#discussion_r754731250
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java
##########
@@ -255,30 +255,18 @@ private void rollBackIndex() {
protected void finishRollback(HoodieInstant inflightInstant,
HoodieRollbackMetadata rollbackMetadata) throws HoodieIOException {
try {
- writeToMetadata(rollbackMetadata);
+ if (!skipLocking && config.isMetadataTableEnabled()) {
+ this.txnManager.beginTransaction(Option.empty(), Option.empty());
+ }
+ writeTableMetadata(rollbackMetadata);
Review comment:
Same here.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java
##########
@@ -205,31 +205,19 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
Option.of(timer.endTimer()),
cleanStats
);
- writeMetadata(metadata);
+ if (!skipLocking && config.isMetadataTableEnabled()) {
+ this.txnManager.beginTransaction(Option.empty(), Option.empty());
+ }
+ writeTableMetadata(metadata);
Review comment:
This should not be invoked if metadata table is disabled? It is not
invoked in the original code if metadata table is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
