yihua commented on a change in pull request #4037:
URL: https://github.com/apache/hudi/pull/4037#discussion_r754733060
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java
##########
@@ -205,31 +205,19 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
Option.of(timer.endTimer()),
cleanStats
);
- writeMetadata(metadata);
+ if (!skipLocking && config.isMetadataTableEnabled()) {
+ this.txnManager.beginTransaction(Option.empty(), Option.empty());
+ }
+ writeTableMetadata(metadata);
Review comment:
@nsivabalan After looking at `writeTableMetadata()` method, it looks
like that the method is a no-op if metadata table is disabled. Just to confirm
if that's the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
