vinothchandar commented on a change in pull request #4013:
URL: https://github.com/apache/hudi/pull/4013#discussion_r754768668
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
##########
@@ -142,6 +142,17 @@
.sinceVersion("0.9.0")
.withDocumentation("When rewriting data, preserves existing
hoodie_commit_time");
+ /**
+ * Using space-filling curves to optimize the layout of table to boost query
performance.
+ * The table data which sorted by space-filling curve has better aggregation;
+ * combine with min-max filtering, it can achieve good performance
improvement.
+ *
+ * Notice:
Review comment:
wondering how much of this should go into the config docs itself?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieColumnRangeMetadata.java
##########
@@ -30,16 +28,28 @@
private final String columnName;
private final T minValue;
private final T maxValue;
- private final long numNulls;
- private final PrimitiveStringifier stringifier;
+ private long numNulls;
+ // For Decimal Type/Date Type, minValue/maxValue cannot represent it's
original value.
+ // eg: when parquet collects column information, the decimal type is
collected as int/binary type.
+ // so we cannot use minValue and maxValue directly, use
minValueAsString/maxValueAsString instead.
+ private final String minValueAsString;
Review comment:
sounds good to me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
