vinothchandar commented on a change in pull request #3952:
URL: https://github.com/apache/hudi/pull/3952#discussion_r754786477
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/optimize/ZOrderingUtil.java
##########
@@ -176,9 +176,17 @@ public static byte updatePos(byte a, int apos, byte b, int
bpos) {
public static Long convertStringToLong(String a) {
Review comment:
do we have UT for these?
##########
File path:
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestOptimizeTable.scala
##########
@@ -64,8 +64,11 @@ class TestOptimizeTable extends HoodieClientTestBase {
}
@ParameterizedTest
- @ValueSource(strings = Array("COPY_ON_WRITE", "MERGE_ON_READ"))
- def testOptimizewithClustering(tableType: String): Unit = {
+ @ValueSource(strings = Array("COPY_ON_WRITE, hilbert", "COPY_ON_WRITE,
z-order", "MERGE_ON_READ, hilbert", "MERGE_ON_READ, z-order"))
Review comment:
can we have two parameters? instead of the comma based splits.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/optimize/HilbertCurve.java
##########
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.optimize;
+
+import java.math.BigInteger;
+import java.util.Arrays;
+
+/**
+ * Converts between Hilbert index ({@code BigInteger}) and N-dimensional
points.
+ *
+ * <p>
+ * Note:
+ * <a
href="https://github.com/davidmoten/hilbert-curve/blob/master/src/main/java/org/davidmoten/hilbert/HilbertCurve.java";>GitHub</a>).
Review comment:
this probably needs to be added to the NOTICE? cc @leesf @yanghua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
