vinothchandar commented on a change in pull request #4080:
URL: https://github.com/apache/hudi/pull/4080#discussion_r757658029
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/replication/GlobalHiveSyncTool.java
##########
@@ -36,8 +38,12 @@
private static final Logger LOG = LogManager.getLogger(HiveSyncTool.class);
+ private final HoodieHiveClient hoodieHiveClient;
+
public GlobalHiveSyncTool(GlobalHiveSyncConfig cfg, HiveConf configuration,
FileSystem fs) {
super(cfg, configuration, fs);
+ ValidationUtils.checkArgument((syncClient instanceof HoodieHiveClient),
"GlobalHiveSyncTool only support Hive Sync. For Glue meta sync, use
HiveSyncTool with the same config");
Review comment:
lets not leak context of other sync tools into this one? remove "glue"
mentions?
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -650,6 +654,18 @@ public void syncHive(HiveConf conf) {
syncHive();
}
+ private void syncGlue() {
Review comment:
We need to keep `DeltaSync` free of any one catalog sync. Can't this
work via reflection?
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -620,6 +621,9 @@ private void syncMeta(HoodieDeltaStreamerMetrics metrics) {
case "org.apache.hudi.hive.HiveSyncTool":
syncHive();
break;
+ case "org.apache.hudi.hive.AwsGlueCatalogSyncTool":
Review comment:
why not flow this into the default below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
