harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773598781
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -54,9 +55,9 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames,
Schema schema) {
int
outputSparkPartitions) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
- return records.sortBy(
+ return CustomJavaRDD.fromRDD(records,records.classTag()).sortBy(
Review comment:
Yes we just want to sort it deterministic way , `null_first` or `null_last`
`public static Object getRecordColumnValues(HoodieRecord<? extends
HoodieRecordPayload> record,
String[] columns,
SerializableSchema schema)`
return type is `object`
if we can make it string then we don't need to write own sortBy
implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
