imbajin commented on code in PR #2952: URL: https://github.com/apache/hugegraph/pull/2952#discussion_r2878260896
########## docker/docker-compose-3pd-3store-3server.yml: ########## @@ -15,166 +15,218 @@ # limitations under the License. # -# TODO: reuse the configs for same type containers -# User could modify the node nums and the port by themselves -version: "3" +name: hugegraph-3x3 + +networks: + hg-net: + driver: bridge + ipam: + config: + - subnet: 172.20.0.0/24 + +volumes: + hg-pd0-data: + hg-pd1-data: + hg-pd2-data: + hg-store0-data: + hg-store1-data: + hg-store2-data: + +# ── Shared service templates ────────────────────────────────────────── + +x-pd-common: &pd-common Review Comment: ⚠️ **`x-pd-common` template is missing `networks: [hg-net]`** The `x-store-common` and `x-server-common` templates both include `networks: [hg-net]`, but `x-pd-common` does not. Each PD service currently works around this by inlining its own `networks:` block, but the template is incomplete. Anyone adding a new PD node while following the existing pattern would end up with a container not connected to the bridge network. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
