imbajin commented on code in PR #2952:
URL: https://github.com/apache/hugegraph/pull/2952#discussion_r2878262093
##########
docker/docker-compose-3pd-3store-3server.yml:
##########
@@ -15,166 +15,218 @@
# limitations under the License.
#
-# TODO: reuse the configs for same type containers
-# User could modify the node nums and the port by themselves
-version: "3"
+name: hugegraph-3x3
+
+networks:
+ hg-net:
+ driver: bridge
+ ipam:
+ config:
+ - subnet: 172.20.0.0/24
+
+volumes:
+ hg-pd0-data:
+ hg-pd1-data:
+ hg-pd2-data:
+ hg-store0-data:
+ hg-store1-data:
+ hg-store2-data:
+
+# ── Shared service templates ──────────────────────────────────────────
+
+x-pd-common: &pd-common
+ image: hugegraph/pd:${HUGEGRAPH_VERSION:-latest}
+ pull_policy: always
Review Comment:
⚠️ **`pull_policy: always` will break offline / air-gapped deployments**
With `pull_policy: always`, every `docker compose up` attempts to pull the
latest image from the registry. This will fail in environments without internet
access (air-gapped servers, CI with no egress, etc.).
Consider changing to `pull_policy: missing` (pull only if the image is not
present locally), which is safer as a default while still ensuring a fresh pull
when images are not cached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
