Copilot commented on code in PR #2965:
URL: https://github.com/apache/hugegraph/pull/2965#discussion_r2909677165
##########
hugegraph-store/README.md:
##########
@@ -109,7 +109,7 @@ mvn clean package -pl hugegraph-store/hugegraph-store-dist
-am -DskipTests
The assembled distribution will be available at:
```
-hugegraph-store/apache-hugegraph-store-incubating-1.7.0/lib/hg-store-node-1.7.0.jar```
+hugegraph-store/apache-hugegraph-store-1.7.0/lib/hg-store-node-1.7.0.jar```
Review Comment:
The Markdown code block for the assembled distribution path is malformed: it
opens a fenced block, but the path line ends with an extra closing fence
("```"), and then another fence appears on the next line. This renders
incorrectly in Markdown; adjust the fencing so the path appears inside a single
code block.
```suggestion
hugegraph-store/apache-hugegraph-store-1.7.0/lib/hg-store-node-1.7.0.jar
```
##########
install-dist/pom.xml:
##########
@@ -50,9 +50,9 @@
cd $root_path || exit
mkdir -p ${final.name}
- cp -r -v
$root_path/hugegraph-pd/apache-hugegraph-pd-incubating-${project.version}
${final.name}/ || exit
- cp -r -v
$root_path/hugegraph-store/apache-hugegraph-store-incubating-${project.version}
${final.name}/ || exit
- cp -r -v
$root_path/hugegraph-server/apache-hugegraph-server-incubating-${project.version}
${final.name}/ || exit
+ cp -r -v
$root_path/hugegraph-pd/apache-hugegraph-pd-${project.version} ${final.name}/
|| exit
+ cp -r -v
$root_path/hugegraph-store/apache-hugegraph-store-${project.version}
${final.name}/ || exit
+ cp -r -v
$root_path/hugegraph-server/apache-hugegraph-server-${project.version}
${final.name}/ || exit
cp -r -v
$root_path/install-dist/release-docs/* $root_path/DISCLAIMER ${final.name}/ ||
exit
Review Comment:
The dist packaging step still copies `$root_path/DISCLAIMER`, but
`DISCLAIMER` is removed in this PR. This will make `mvn package` for
`install-dist` fail with a missing file error. Update the copy command to stop
referencing `DISCLAIMER` (or add the replacement file to the dist if one is
still required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
