Copilot commented on code in PR #2965:
URL: https://github.com/apache/hugegraph/pull/2965#discussion_r2917007549
##########
hugegraph-store/docs/development-guide.md:
##########
@@ -216,7 +216,7 @@ hg-store-grpc/
**Start Server**:
```bash
-cd hugegraph-store/hg-store-dist/target/apache-hugegraph-store-incubating-1.7.0
+cd hugegraph-store/hg-store-dist/target/apache-hugegraph-store-1.7.0
Review Comment:
The “Start Server” example `cd
hugegraph-store/hg-store-dist/target/apache-hugegraph-store-1.7.0` appears to
point to a non-existent directory given the current `hg-store-dist` build
config (assembly output is written to `hugegraph-store/`, not
`hg-store-dist/target`). This will cause the documented start commands to fail;
please update the path to the actual assembled distribution directory.
```suggestion
cd hugegraph-store/apache-hugegraph-store-1.7.0
```
##########
hugegraph-store/docs/development-guide.md:
##########
@@ -58,7 +58,7 @@ git checkout 1.7-rebase
2. Add new "Application" configuration:
- Main class: `org.apache.hugegraph.store.node.StoreNodeApplication`
- VM options: `-Xms4g -Xmx4g -Dconfig.file=conf/application.yml`
- - Working directory:
`hugegraph-store/hg-store-dist/target/apache-hugegraph-store-incubating-1.7.0`
+ - Working directory:
`hugegraph-store/hg-store-dist/target/apache-hugegraph-store-1.7.0`
Review Comment:
The documented working directory
`hugegraph-store/hg-store-dist/target/apache-hugegraph-store-1.7.0` doesn’t
match the actual assembly output location. `hg-store-dist` is configured to
write the assembled directory into the parent `hugegraph-store/` directory (via
`outputDirectory=${dist.dir}`), so this path will likely not exist after
packaging and will break the run configuration instructions. Please update the
doc to point at the real assembled directory path.
```suggestion
- Working directory: `hugegraph-store/apache-hugegraph-store-1.7.0`
```
##########
hugegraph-store/docs/development-guide.md:
##########
@@ -242,7 +242,7 @@ mvn compile
```bash
mvn clean package -DskipTests
-# Output:
hg-store-dist/target/apache-hugegraph-store-incubating-<version>.tar.gz
+# Output: hg-store-dist/target/apache-hugegraph-store-<version>.tar.gz
Review Comment:
The documented distribution output path
`hg-store-dist/target/apache-hugegraph-store-<version>.tar.gz` doesn’t match
the build: the `hg-store-dist` module writes the tarball into the parent
`hugegraph-store/` directory (see `outputDirectory=${dist.dir}` and `tar ...
${dist.dir}/${final.name}.tar.gz`). Please update the doc so users can find the
produced tarball.
```suggestion
# Output: hugegraph-store/apache-hugegraph-store-<version>.tar.gz
```
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh:
##########
@@ -35,7 +35,7 @@ mvn package -Dmaven.test.skip=true -ntp
wget -P $SERVER_DIR/lib/
https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.28/mysql-connector-java-8.0.28.jar
if [[ ! -e "$SERVER_DIR/ikanalyzer-2012_u6.jar" ]]; then
Review Comment:
This existence check is looking for `ikanalyzer-2012_u6.jar` in
`$SERVER_DIR`, but the `wget -P` command saves it under `$SERVER_DIR/lib/`. As
written, the condition will always be true (unless a different file happens to
exist), causing an unnecessary re-download on every run and extra network
flakiness. Update the check to test for the file in the same directory it’s
downloaded to.
```suggestion
if [[ ! -e "$SERVER_DIR/lib/ikanalyzer-2012_u6.jar" ]]; then
```
##########
hugegraph-pd/AGENTS.md:
##########
@@ -110,7 +110,7 @@ mvn clean install
# Build distribution package only
mvn clean package -pl hg-pd-dist -am -DskipTests
-# Output: hg-pd-dist/target/apache-hugegraph-pd-incubating-<version>.tar.gz
+# Output: hg-pd-dist/target/apache-hugegraph-pd-<version>.tar.gz
Review Comment:
The documented output location
`hg-pd-dist/target/apache-hugegraph-pd-<version>.tar.gz` doesn’t match the
`hg-pd-dist` build configuration: the assembly is configured to place the
tarball in the parent `hugegraph-pd/` directory (`outputDirectory=${dist.dir}`
and `tar ... ${dist.dir}/${final.name}.tar.gz`). Please update this path so the
instructions reflect the actual build output.
```suggestion
# Output: hugegraph-pd/apache-hugegraph-pd-<version>.tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
