bitflicker64 commented on PR #2952:
URL: https://github.com/apache/hugegraph/pull/2952#issuecomment-4029115619
> Overall this PR looks good to me now.
>
> The overall direction makes sense, and I really appreciate all the work
you’ve put into this, especially the follow-up updates during review. Thanks a
lot for the contribution and for continuing to improve it.
>
> Once the last small issue is fixed and confirmed, I think it would be
reasonable to merge it first and validate it in real-world use.
@imbajin I'll get the remaining fix done shortly.
Also wanted to flag something I noticed while testing `docker logs` doesn't
work properly for any of the HugeGraph containers right now. The startup
scripts redirect JVM output to files inside the container (`>> ${OUTPUT}
2>&1`), so nothing reaches Docker's log capture. On top of that, the console
appender is defined in the Log4j2 dist configs but never wired to the root
logger. This means during debugging I had to manually exec into the container
and tail the log files directly.
I also noticed the non-dist `log4j2.xml` configs already have the console
appender wired correctly — the dist configs just never got updated to match.
Should I open a separate PR for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
