imbajin commented on PR #2952:
URL: https://github.com/apache/hugegraph/pull/2952#issuecomment-4029182006
> Also wanted to flag something I noticed while testing `docker logs`
doesn't work properly for any of the HugeGraph containers right now. The
startup scripts redirect JVM output to files inside the container (`>>
${OUTPUT} 2>&1`), so nothing reaches Docker's log capture. On top of that, the
console appender is defined in the Log4j2 dist configs but never wired to the
root logger. This means during debugging I had to manually exec into the
container and tail the log files directly.
>
> I also noticed the non-dist `log4j2.xml` configs already have the console
appender wired correctly ā the dist configs just never got updated to match.
Should I open a separate PR for this?
Thanks for catching that while testing ā that does sound like a real issue.
Iād lean toward a separate PR for it, since it feels a bit beyond the main
scope of this one. Keeping it separate would make this PR easier to land first,
and the logging change can be reviewed on its own.
So I think it makes sense to finish the remaining fix here, and open a
follow-up PR for the `docker logs` / dist logging config issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]