spetz commented on code in PR #1624: URL: https://github.com/apache/iggy/pull/1624#discussion_r1991835137
########## server/src/binary/handlers/segments/delete_segments_handler.rs: ########## @@ -0,0 +1,71 @@ +/* Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use crate::binary::{handlers::partitions::COMPONENT, sender::SenderKind}; +use crate::state::command::EntryCommand; +use crate::streaming::session::Session; +use crate::streaming::systems::system::SharedSystem; +use anyhow::Result; +use error_set::ErrContext; +use iggy::error::IggyError; +use iggy::segments::delete_segments::DeleteSegments; +use tracing::{debug, instrument}; + +#[instrument(skip_all, name = "trace_delete_segments", fields(iggy_user_id = session.get_user_id(), iggy_client_id = session.client_id, iggy_stream_id = command.stream_id.as_string(), iggy_topic_id = command.topic_id.as_string()))] +pub async fn handle( + command: DeleteSegments, + sender: &mut SenderKind, + session: &Session, + system: &SharedSystem, +) -> Result<(), IggyError> { + debug!("session: {session}, command: {command}"); + let stream_id = command.stream_id.clone(); + let topic_id = command.topic_id.clone(); + + let mut system = system.write().await; + system + .delete_segments( + session, + &command.stream_id, + &command.topic_id, + command.partition_id, + command.segments_count, + ) + .await + .with_error_context(|error| { + format!( + "{COMPONENT} (error: {error}) - failed to delete partitions for topic with ID: {topic_id} in stream with ID: {stream_id}, session: {session}", + ) + })?; + + let system = system.downgrade(); + system + .state + .apply( + session.get_user_id(), + EntryCommand::DeleteSegments(command), + ) + .await + .with_error_context(|error| { + format!( + "{COMPONENT} (error: {error}) - failed to apply delete partitions for stream_id: {}, topic_id: {}, session: {}", Review Comment: `delete segments`, not partitions :) Let's also fix the formatting a bit, so it could look like this: ``` format!( "{COMPONENT} (error: {error}) - failed to delete segments for partition with ID: {partition_id} in topic with ID: {topic_id} in stream with ID: {stream_id}, session: {session}", ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
