ilikepi63 commented on code in PR #1624:
URL: https://github.com/apache/iggy/pull/1624#discussion_r1990901468


##########
sdk/src/segments/delete_segments.rs:
##########
@@ -0,0 +1,182 @@
+use crate::bytes_serializable::BytesSerializable;
+use crate::command::{Command, DELETE_SEGMENTS_CODE};
+use crate::error::IggyError;
+use crate::identifier::Identifier;
+use crate::utils::sizeable::Sizeable;
+use crate::validatable::Validatable;
+use bytes::{BufMut, Bytes, BytesMut};
+use serde::{Deserialize, Serialize};
+use std::fmt::Display;
+
+use super::MAX_SEGMENTS_COUNT;
+
+type SegmentsCountType = u32;

Review Comment:
   Fixed this - realized it wasn't a great idea. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to