Copilot commented on code in PR #1679:
URL: https://github.com/apache/iggy/pull/1679#discussion_r2030256260
##########
bench/src/benchmarks/benchmark.rs:
##########
@@ -69,7 +69,7 @@ impl From<IggyBenchArgs> for Box<dyn Benchmarkable> {
BenchmarkKindCommand::EndToEndProducingConsumerGroup(_) =>
Box::new(
EndToEndProducingConsumerGroupBenchmark::new(Arc::new(args),
client_factory),
),
- _ => todo!(),
+ _ => unreachable!(),
Review Comment:
Using unreachable!() here might lead to a panic if additional benchmark
types are introduced in the future. Consider handling unknown benchmark
commands gracefully, perhaps by returning a descriptive error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
