spetz commented on code in PR #1679: URL: https://github.com/apache/iggy/pull/1679#discussion_r2050980231
########## configs/server.toml: ########## @@ -461,17 +451,29 @@ enforce_fsync = false # `false` skips these checks for faster loading at the risk of undetected corruption. validate_checksum = false -# The threshold of buffered messages before triggering a save to disk (integer). +# The count threshold of buffered messages before triggering a save to disk (integer). # Specifies how many messages accumulate before persisting to storage. # Adjusting this can balance between write performance and data durability. +# This is soft limit, actual number of messages may be higher, depending on last batch size. +# Together with `size_of_messages_required_to_save` it defines the threshold of buffered messages. +# Minimum value is 32. Review Comment: Let's extend this comment with `why 32`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
