haze518 commented on code in PR #1922: URL: https://github.com/apache/iggy/pull/1922#discussion_r2173267556
########## bdd/go/tests/tcp/consumers_feature_join.go: ########## @@ -15,7 +15,7 @@ // specific language governing permissions and limitations // under the License. -package tcp_test +package tcp Review Comment: it’s mostly out of curiosity :) Honestly, you can leave it like that — we do it pretty often at work, since sometimes we need to test not only public functions. (Yeah, testing private funcs isn’t exactly ideal, but it’s often just more convenient) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
