chengxilo commented on code in PR #1922: URL: https://github.com/apache/iggy/pull/1922#discussion_r2173276071
########## bdd/go/tests/tcp/consumers_feature_join.go: ########## @@ -15,7 +15,7 @@ // specific language governing permissions and limitations // under the License. -package tcp_test +package tcp Review Comment: As you may have noticed, I created a new Go module for testing. Initially, I didn't intend to test private functions within the BDD tests. When I encountered the package naming issue, I wasn't aware that it was related to accessing public vs. private functions — I only changed the package name to avoid duplication. That was my mistake, and I’ll fix it. As for the private functions, I believe it's better to test them in unit tests under foreign/go. That way, we keep the BDD tests focused and clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
