hubcio commented on code in PR #2452: URL: https://github.com/apache/iggy/pull/2452#discussion_r2652324017
########## core/configs/server.toml: ########## @@ -366,6 +366,13 @@ file_enabled = true # Maximum size of the log files before rotation. max_size = "512 MB" Review Comment: this is misleading if you look at lines 369 to 371 - please rename to `max_file_size` and update description (assuming i'm right) (i know its breaking change but we're under 1.0.0, lets do it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
