hubcio commented on code in PR #2452:
URL: https://github.com/apache/iggy/pull/2452#discussion_r2652318899
##########
core/server/src/configs/defaults.rs:
##########
@@ -403,6 +403,8 @@ impl Default for LoggingConfig {
level: SERVER_CONFIG.system.logging.level.parse().unwrap(),
file_enabled: SERVER_CONFIG.system.logging.file_enabled,
max_size: SERVER_CONFIG.system.logging.max_size.parse().unwrap(),
+ max_total_size:
SERVER_CONFIG.system.logging.max_total_size.parse().unwrap(),
+ rotation_check_interval:
SERVER_CONFIG.system.logging.rotation_check_interval as u64,
Review Comment:
please use `IggyDuration`, set default value to `"1 h"` (in `server.toml`)
and create `impl Validate for LoggingConfig`, in the validator check if its
higher than `1 s` and check if `max_total_size >= max_size` (or `max_file_size`)
(see `validators.rs`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
