hubcio commented on code in PR #2529:
URL: https://github.com/apache/iggy/pull/2529#discussion_r2678591367
##########
core/sdk/src/clients/consumer.rs:
##########
@@ -918,6 +920,34 @@ impl ReceivedMessage {
}
}
+fn maybe_decompress(message: &mut IggyMessage) -> Result<(), IggyError> {
+ if let Ok(Some(algorithm_value)) =
+
message.get_user_header(&HeaderKey::from_str(COMPRESSION_HEADER_KEY).unwrap())
+ {
+ let algorithm_name = algorithm_value.as_str().unwrap();
Review Comment:
it's unacceptable to crash the client: please return the error to caller,
create a new variant IggyError::InvalidCompressionHeaderKey(String) and then
use it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
