mmodzelewski commented on code in PR #2606:
URL: https://github.com/apache/iggy/pull/2606#discussion_r2812850005
##########
foreign/java/java-sdk/src/main/java/org/apache/iggy/client/async/tcp/AsyncIggyTcpClient.java:
##########
@@ -95,7 +95,13 @@ public static Builder builder() {
* Connects to the Iggy server asynchronously.
*/
public CompletableFuture<Void> connect() {
- connection = new AsyncTcpConnection(host, port, enableTls,
tlsCertificate);
+ // 1. Create the pool configuration from builder/client fields
+ AsyncTcpConnection.TCPConnectionPoolConfig poolConfig = new
AsyncTcpConnection.TCPConnectionPoolConfig(
+ connectionPoolSize.orElse(5), // Default to 5 if not provided
+ 1000, // maxPendingAcquires
+ connectionTimeout.map(Duration::toMillis).orElse(3000L) // map
Duration to millis
Review Comment:
@rythm-sachdeva please address this comment. The numeric values should be
declared as static final. If any value has a default in the builder, it should
be aligned in both places. Also, please remove the inline comments, the code is
self-explanatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
