rythm-sachdeva commented on code in PR #2606:
URL: https://github.com/apache/iggy/pull/2606#discussion_r2850278534
##########
foreign/java/java-sdk/src/main/java/org/apache/iggy/client/async/tcp/AsyncIggyTcpClient.java:
##########
@@ -158,7 +159,15 @@ public static AsyncIggyTcpClientBuilder builder() {
* @return a {@link CompletableFuture} that completes when the connection
is established
*/
public CompletableFuture<Void> connect() {
- connection = new AsyncTcpConnection(host, port, enableTls,
tlsCertificate);
+ TCPConnectionPoolConfig.Builder poolConfigBuilder = new
TCPConnectionPoolConfig.Builder();
+ if (connectionPoolSize.isPresent()) {
+ poolConfigBuilder.setMaxConnections(connectionPoolSize.get());
+ }
+ if (connectionTimeout.isPresent()) {
+
poolConfigBuilder.setAcquireTimeoutMillis(connectionTimeout.get().toMillis());
Review Comment:
I think by mistake I have given the wrong name it should be acquireTimeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
