chengxilo commented on PR #2737: URL: https://github.com/apache/iggy/pull/2737#issuecomment-3918680103
@ex172000 regarding the request for tests and the common struct: I actually hesitated on this because the current foreign/go/contract directory is already quite cluttered, with types for various purposes mixed together. To avoid suffering in the cluttered types, I believe we should reorganize the directory structure in foreign/go to better categorize these types. However, if I include that reorganization and the new tests in this PR, the "lines changed" will explode, making this a >3000 lines of change(or even more, I don't know). My proposal: 1. I will fix the naming consistency for `ConsumerGroupId`/`GroupId` now. And probably introduce the common struct. 2. We merge this PR. 3. After that, I will submit some follow-up PR focused solely on reorganizing the directory and adding the unit tests you suggested. I think it would make the review process easier. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
