chengxilo commented on PR #2737:
URL: https://github.com/apache/iggy/pull/2737#issuecomment-3924027492
> > Hey @ex172000, I added that common struct `TopicPath` for the group
commands. I didn't embed it into `ConsumerGroupInfo` on purpose as we might
split these into different packages later. I’d rather keep the request types
and the data models separate so they don't get all tangled up.
>
> Thanks for the update! Just wondering, some of the fields are still having
JSON annotation, but new ones don't. Do we need it or we can drop it completely?
The JSON annotations seem to be autogenerated code from previous maintainer.
They actually do nothing since HTTP is not implemented yet.
I don't think we will implement the HTTP within a short term of time.
Since currently they are useless and may not align with the JSON we
actually need in HTTP SDK, maybe I can remove them all in another PR.🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
