hubcio commented on code in PR #2921:
URL: https://github.com/apache/iggy/pull/2921#discussion_r2936618957
##########
core/common/src/alloc/memory_pool.rs:
##########
@@ -16,26 +16,25 @@
* under the License.
*/
-use bytes::BytesMut;
+use aligned_vec::{AVec, ConstAlign};
use crossbeam::queue::ArrayQueue;
use human_repr::HumanCount;
use once_cell::sync::OnceCell;
use std::sync::Arc;
use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};
use tracing::{info, trace, warn};
+pub const ALIGNMENT: usize = 4096;
Review Comment:
please make it configurable via compilation feature. it can be either 512 or
4096. make 512 a default feature - is that reasonable? or, is there any reason
why is 4096 hardcoded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
