tungtose commented on PR #2921: URL: https://github.com/apache/iggy/pull/2921#issuecomment-4063195196
> > make_mutable in the HTTP path now copies buffers due to alignment incompatibility with Bytes > > can you elaborate? Correct me if I'm wrong, to make the make_mutable function in the HTTP path zero copy, we need to change `IggyMessagesBatch` to store `PooledBuffer` instead of `Bytes`. However, `IggyMessagesBatch` is a core type with dependencies throughout the codebase, so this could be refactored in a separate PR if needed Other than that, make_mutable is not in the hot path. If user is using the HTTP API for high-throughput message sending, they already have bigger problems than this one copy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
