chengxilo commented on code in PR #2973: URL: https://github.com/apache/iggy/pull/2973#discussion_r2962171338
########## foreign/go/contracts/users.go: ########## Review Comment: This part should not use byte(0) directly, doesn't align with the behavior in rust sdk. https://github.com/apache/iggy/blob/9c8b5cc6ca682de6f3e7e0074224517e5488dc40/core/common/src/types/permissions/permissions_global.rs#L267-L273 @saie-ch would you mind to solve this in another PR first (to Implement unit test for permission and fix the problem in permission)? ########## foreign/go/contracts/users.go: ########## @@ -99,7 +99,7 @@ func (p *Permissions) MarshalBinary() ([]byte, error) { } } } else { - bytes[0] = byte(0) + bytes[position] = byte(0) Review Comment: You can solve this in the new PR too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
