chengxilo commented on code in PR #2973:
URL: https://github.com/apache/iggy/pull/2973#discussion_r2962372305
##########
foreign/go/internal/command/update_user.go:
##########
@@ -43,14 +43,14 @@ func (u *UpdateUser) MarshalBinary() ([]byte, error) {
username := *u.Username
Review Comment:
Here the `u.Username` is actually modified by the method, I don't think it's
a good approach. Since you are already modifying this functino, would you mind
to modified this too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
