amlel-el-mahrouss commented on code in PR #2988:
URL: https://github.com/apache/iggy/pull/2988#discussion_r2969599039
##########
foreign/cpp/src/client.rs:
##########
@@ -53,22 +53,22 @@ pub fn new_connection(connection_string: String) ->
Result<*mut Client, String>
}
impl Client {
- pub fn connect(&self) -> Result<(), String> {
+ pub fn login_user(&self, username: String, password: String) -> Result<(),
String> {
Review Comment:
Nevermind, i dont think my question was a good one anyways, putting username
and password in the Client type would be not a good design decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
